-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated PackageInfo.signatures with PackageInfo.signingInfo #1587
Merged
paulkagiri
merged 13 commits into
dev
from
feature/replace_deprecated_packageInfo.signatures
Apr 15, 2021
Merged
Replaced deprecated PackageInfo.signatures with PackageInfo.signingInfo #1587
paulkagiri
merged 13 commits into
dev
from
feature/replace_deprecated_packageInfo.signatures
Apr 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulkagiri
requested review from
shoatman,
iambmelt,
rpdome,
AdamBJohnsonx and
gitaumoses4
March 4, 2021 08:10
…ttps://github.com/AzureAD/azure-activedirectory-library-for-android into feature/replace_deprecated_packageInfo.signatures
iambmelt
previously approved these changes
Apr 12, 2021
gitaumoses4
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the deprecated
PackageInfo.signatures
withPackageInfo.signingInfo
. Created a utility method across code and tests for compatibility reasons.Work Item: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/1226178
Issue: AzureAD/microsoft-authentication-library-common-for-android#851